Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pavel

On 4/28/20 3:43 AM, Pavel Machek wrote:
On Mon 2020-04-27 12:12:18, Dan Murphy wrote:
Pavel

On 4/25/20 2:52 PM, Pavel Machek wrote:
On Thu 2020-04-23 10:55:09, Dan Murphy wrote:
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.

Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
Please merge with previous patch, and you can keep reviews.
Not sure we should do that.  The previous patches deals directly with the
bindings and this is code.

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings document
patch but it does not make sense to squash this patch to the bindings.

Please let me know if you want me to proceed with the squash.
Well, OTOH it seems wrong to have array that is only
half-initialized... But it is not a big deal.

I will squash it into the previous patch as you asked.  Like you said it is not a big deal.

Dan




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux