On Sat 2020-03-21 23:36:38, Marek Behun wrote: > On Sat, 21 Mar 2020 23:16:53 +0100 > Pavel Machek <pavel@xxxxxx> wrote: > > > Hi! > > > > > The microcontroller on Turris Omnia supports more settings than just > > > LEDs (usb3 port power and input button for example). > > > > > > I am wondering if this approach (registering LED driver to > > > communicate with the microcontroller) is correct, since the > > > microcontroller can do other things. > > > > > > For Turris Mox firmware I created a driver in > > > drivers/firmware/turris-mox-rwtm.c. > > > > this should be drivers/platform/turris/, I believe. It is not > > _firmware_, is it? > > It is code that interacts with the firmware. It already is merged in > drivers/firmware/. The raspberrypi firmware interacting drivers is > also Everything has firmware these days, so everything is interacting with firmware. We have drivers/platform, not drivers/firmware/sata. drivers/firmware is for firmware that runs on _main_ CPU. drivers/platform is for talking with embedded controllers (that may have their own firmware). But I suggest you put it all into drivers/leds for now, and then maybe move it, because otherwise it will be nightmare for maintainers. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature
