Hi Pavel,
are you willing to give this patch a try in favor of 3/5?
Or shall I resent the fixed series?
Regards Denis
Am Montag, den 23.03.2020, 10:14 +0100 schrieb Denis Osterland-Heim:
> led_pwm_set() now returns an error when setting the PWM fails.
>
> Signed-off-by: Denis Osterland-Heim <Denis.Osterland@xxxxxxxxx>
> ---
> drivers/leds/leds-pwm.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index 6caf8bea8cd5..07eab2d8b7c7 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -91,15 +91,21 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
> pwm_init_state(led_data->pwm, &led_data->pwmstate);
>
> ret = devm_led_classdev_register(dev, &led_data->cdev);
> - if (ret == 0) {
> - priv->num_leds++;
> - led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
> - } else {
> + if (ret) {
> dev_err(dev, "failed to register PWM led for %s: %d\n",
> led->name, ret);
> + return ret;
> }
>
> - return ret;
> + ret = led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
> + if (ret) {
> + dev_err(dev, "failed to set led PWM value for %s: %d",
> + led->name, ret);
> + return ret;
> + }
> +
> + priv->num_leds++;
> + return 0;
> }
>
> static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________
Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
