On Sat, 28 Mar 2020 13:08:02 +0100 Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > Hi Pavel. > > On 3/21/20 4:33 PM, Pavel Machek wrote: > > Hi! > > > >> This adds basic support for LEDs on the front side of CZ.NIC's Turris > >> Omnia router. > > > > Looks good, I had to apply it by hand, by I took it. I realize that > > dts interface may not be final, but I do not want to solve Makefile > > rejects in future. > > I don't think it is a good idea to merge it without bindings, > and with DT parser that will certainly undergo essential changes. > > Besides, you appear as the commit author in your tree and moreover > the patch has a broken title. Also the commit message contains > DT bindings that will have different shape eventually. > > NACK for merging this patch in this shape. > This was only RFC, please do not merge.
