Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> +	if (led->color != color) {
> +		dev_warn(dev, "Node %pfw: 'color' should be %s!\n", node,
> +			 led_colors[color]);
> +		return 0;
> +	}
> +
> +	init_data.devicename = "omnia";
> +	init_data.fwnode = node;
> +	init_data.devname_mandatory = true;

How will this look in the /sys/class/leds?

We don't want to see omnia:xxx:xx there. For the ethernet activity
leds, it would be nice to get something like eth0:red:activity...?

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux