On Thu, Feb 13, 2020 at 11:27 AM Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx> wrote: > > This function is in the same spirit as the other kstrto* functions and > uses the same calling convention. It expects the input string to be in > the format %u:%u and implements stricter parsing than sscanf as it > returns an error on trailing data (other than the usual \n). Can we first split the kstrotox* (and simple_strto*) to the separate header first? On top of that, why kstrtodev_t is so important? How many users are already in the kernel to get an advantage out of it? What to do with all other possible variants ("%d:%d", "%dx%d" and its %u variant, etc)? Why simple_strto*() can't be used? > #include <linux/export.h> > #include <linux/types.h> > #include <linux/uaccess.h> > +#include <linux/kdev_t.h> Perhaps preserve order? (It's for the future, since I doubt we will get this in upstream anyway). -- With Best Regards, Andy Shevchenko