Hi Pavel, On Thu, Dec 26, 2019 at 11:29:56AM +0100, Pavel Machek wrote: > On Wed 2019-12-25 12:16:39, Guido Günther wrote: > > Otherwise there's a noticeable glow even with brightness 0. Also > > turning off the regulator can save additional power. > > Ok, this will make set brightness slower, but I guess it makes sense. > > Can you try to toggling brightness quickly from userspace, maybe even > from two threads, to ensure nothing really goes wrong there? I ran brightness setting in a tight loop from 0 to max from two threads 100 times without issues. > > Hmm. And if this is independend of the other series, tell me and I can > apply v2. There's minor merge conflict so to make sure this does not get dependent on the order i've folded this to the end of the "leds: lm3692x: Allow to set ovp and brigthness mode" series with your Acked-by's folded in. I'll wait a couple of days and then send out a v3. Cheers and thanks for having a look, -- Guido > > Best regards, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html