Am 12.12.19 um 04:39 schrieb Andreas Färber:
diff --git a/drivers/leds/leds-tm1628.c b/drivers/leds/leds-tm1628.c
index ef85712a84f2..8a8fd1562853 100644
--- a/drivers/leds/leds-tm1628.c
+++ b/drivers/leds/leds-tm1628.c
[...]
@@ -411,9 +412,38 @@ static const struct tm1628_info fd628_info = {
.default_pwm = 0,
};
+static const struct tm1628_mode aip1618_modes[4] = {
+ {
+ .grid_mask = GENMASK(4, 1),
+ .seg_mask = GENMASK(8, 1),
+ },
+ {
+ .grid_mask = GENMASK(5, 1),
+ .seg_mask = GENMASK(7, 1),
+ },
+ {
+ .grid_mask = GENMASK(6, 1),
+ .seg_mask = GENMASK(6, 1),
+ },
These three segment masks are obviously wrong - they violate the
seg_mask below, not leaving the gap between 5 and 12. Fixed.
+ {
+ .grid_mask = GENMASK(7, 1),
+ .seg_mask = GENMASK(5, 1),
+ },
+};
+
+static const struct tm1628_info aip1618_info = {
+ .grid_mask = GENMASK(7, 1),
+ .seg_mask = GENMASK(14, 12) | GENMASK(5, 1),
+ .modes = aip1618_modes,
+ .default_mode = 3,
+ .pwm_map = tm1628_pwm_map,
+ .default_pwm = 0,
+};
[snip]
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
