Hello, v3 of this series was sent earlier today starting with Message-Id: 20191217150736.1479-1-u.kleine-koenig@xxxxxxxxxxxxxx. v4 only changes patch 3 dropping a few printks, fixing the show callback for the dev attribute to match its store function. And I moved ledtrig_tty_restart() into the already existing if (tty) {...} block in dev_store and dropped the same check from the former function. Best regards Uwe Uwe Kleine-König (3): tty: rename tty_kopen() and add new function tty_kopen_shared() tty: new helper function tty_get_icount() leds: trigger: implement a tty trigger drivers/leds/trigger/Kconfig | 7 ++ drivers/leds/trigger/Makefile | 1 + drivers/leds/trigger/ledtrig-tty.c | 153 ++++++++++++++++++++++++++++ drivers/staging/speakup/spk_ttyio.c | 2 +- drivers/tty/tty_io.c | 87 ++++++++++++---- include/linux/tty.h | 7 +- 6 files changed, 232 insertions(+), 25 deletions(-) create mode 100644 drivers/leds/trigger/ledtrig-tty.c -- 2.24.0