On Tue, Oct 8, 2019 at 12:17 PM Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > > On 10/8/19 5:00 PM, Rob Herring wrote: > > On Tue, Oct 8, 2019 at 8:30 AM Jean-Jacques Hiblot <jjhiblot@xxxxxx> wrote: > >> > >> Rob, > >> > >> On 08/10/2019 14:51, Jean-Jacques Hiblot wrote: > >>> Hi Rob, > >>> > >>> On 07/10/2019 18:15, Rob Herring wrote: > >>>> Please send DT bindings to DT list or it's never in my queue. IOW, > >>>> send patches to the lists that get_maintainers.pl tells you to. > >>>> > >>>> On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot <jjhiblot@xxxxxx> > >>>> wrote: > >>>>> Add DT binding for led-backlight. > >>>>> > >>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@xxxxxx> > >>>>> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > >>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > >>>>> --- > >>>>> .../bindings/leds/backlight/led-backlight.txt | 28 > >>>>> +++++++++++++++++++ > >>>>> 1 file changed, 28 insertions(+) > >>>>> create mode 100644 > >>>>> Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > >>>> Please make this a DT schema. > >>> > >>> OK. > >>> > >>> BTW I used "make dt_binding_check" but had to fix a couple of YAMLs > >>> file to get it to work. Do you have a kernel tree with already all the > >>> YAML files in good shape ? Or do you want me to post the changes to > >>> devicetree@xxxxxxxxxxxxxxx ? > >>> > >>> > >>>> > >>>>> diff --git > >>>>> a/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > >>>>> b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > >>>>> new file mode 100644 > >>>>> index 000000000000..4c7dfbe7f67a > >>>>> --- /dev/null > >>>>> +++ > >>>>> b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > >>>>> @@ -0,0 +1,28 @@ > >>>>> +led-backlight bindings > >>>>> + > >>>>> +This binding is used to describe a basic backlight device made of > >>>>> LEDs. > >>>>> +It can also be used to describe a backlight device controlled by > >>>>> the output of > >>>>> +a LED driver. > >>>>> + > >>>>> +Required properties: > >>>>> + - compatible: "led-backlight" > >>>>> + - leds: a list of LEDs > >>>> 'leds' is already used as a node name and mixing is not ideal. > > for the record: child node names (if that was what you had on mind) > have singular form 'led'. I did actually grep this and not rely on my somewhat faulty memory: $ git grep '\sleds {' | wc -l 463 These are mostly gpio-leds I think. Rob