Hi Guido, Thank you for the update. On 9/21/19 11:12 PM, Guido Günther wrote: > The driver currently returns success on init although probing fails and > register setup uses flag values from other registers which is confusing when > reading the driver. This series cleans this up. > > Changes from v2: > - Add Acked-by from Pavel Machek, thanks! > https://lore.kernel.org/linux-leds/20190920114743.GA21835@amd/ > - As per review comment from Dan Murphy > https://lore.kernel.org/linux-leds/2bde2870-08a3-38b9-9cd7-fee0e2107743@xxxxxx/ > - rename return value from ret2 to reg_ret > - print error code > > Changes from v1: > - Add reviewed by's from Dan Murphy, thanks! > https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@xxxxxxxxxxx/T/#mc183f3f65931371fa9f9ca2e0e83e0b85010f24b > https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@xxxxxxxxxxx/T/#mb845fac36327a5d5dd03fe7e988eef0eb5626f82 > https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@xxxxxxxxxxx/T/#m995bce73dda3e3bd4f0c2e8f98cbd04a39c13832 > - As per review comment from Dan Murphy > - Don't drop error message when disabling the regulator fails > https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@xxxxxxxxxxx/T/#m2ab6dc33b7277b71a197c3747847f1c4d9d9c1d8 > - Handle -ENODEV (when the regulator is not set) > https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@xxxxxxxxxxx/T/#mf6212c29bbfa37b43200ea2c9744074de4f068ee > - Add Acked-by from Pavel Machek, thanks! > https://lore.kernel.org/linux-leds/20190919095415.GA29939@amd/ > > Guido Günther (5): > leds: lm3692x: Print error value on dev_err > leds: lm3692x: Don't overwrite return value in error path > leds: lm3692x: Handle failure to probe the regulator > leds: lm3692x: Use flags from LM3692X_BOOST_CTRL > leds: lm3692x: Use flags from LM3692X_BRT_CTRL > > drivers/leds/leds-lm3692x.c | 47 +++++++++++++++++++++++-------------- > 1 file changed, 30 insertions(+), 17 deletions(-) > Patch set applied to the for-5.5 branch of linux-leds.git. -- Best regards, Jacek Anaszewski
