Re: [PATCH v2 leds-next 3/3] leds: turris-omnia: Add support for continuous brightness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/29/19 6:50 PM, Marek Behun wrote:
On Fri, 29 Mar 2019 12:42:48 +0100
Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote:

This "global_brightness" seems to be similar to LEDn_BRIGHTNESS of
TI lp50xx [0] devices that led us to that whole concept of LED multi
color class.

Jacek, global brightness is one setting for all 12 LEDs, not a separate
setting for each RGB LED. It does not make sense to me to incorporate
all 12 RGB LEDs (which are 36 LED channels) into one logical LED with
one brightness setting and then 36 brightnesses (12 for red, 12 for
green, 12 for blue).

Incorporating all 12 LEDs would make no sense. The multi color class
design is devised to represent a multi color LED element like RGB,
RGBAUV etc. Color duplication shall not be allowed.

So, in case of turris-omnia device we will need to expose 4 LEDs,
and document that global brightness is shared between them.

In your current approach I would just skip that since there will
be no means to report the global brightness with current API.

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux