On 3/29/19 12:50 PM, Marek Behun wrote: > On Fri, 29 Mar 2019 12:42:48 +0100 > Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > >> This "global_brightness" seems to be similar to LEDn_BRIGHTNESS of >> TI lp50xx [0] devices that led us to that whole concept of LED multi >> color class. > > Jacek, global brightness is one setting for all 12 LEDs, not a separate > setting for each RGB LED. It does not make sense to me to incorporate > all 12 RGB LEDs (which are 36 LED channels) into one logical LED with > one brightness setting and then 36 brightnesses (12 for red, 12 for > green, 12 for blue). > Well technically the LED framework and design requires each LED to be declared. If a RGB cluster is to be supported by a single register write/read then you need to define the led-sources as well. I will post the updated documentation on Monday But the initial documentation is defined here http://git.ti.com/gitweb/?p=ti-analog-linux-kernel/dmurphy-analog.git;a=blob;f=Documentation/leds/leds-class-multicolor.txt;h=357f045a826aac71d65704891c18e7fb31e5cb9b;hb=a73a8f2ab727875b375aaf7a7082fcb28666aed3 And the code that Jacek is referring to for the LP50xx is here http://git.ti.com/gitweb/?p=ti-analog-linux-kernel/dmurphy-analog.git;a=blob;f=drivers/leds/leds-lp50xx.c;h=56f813a154eb98868307b1bcac5b4b4ff9c0a671;hb=04e055b6eb0c7d9679fcd756850b142afc048cd8 Again both of these are in the process of rework based on comments. Dan -- ------------------ Dan Murphy
