Re: [PATCH v1 2/2] leds: pca955x: Revert "Add ACPI support"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun 2019-03-17 22:44:22, Andy Shevchenko wrote:
> On Sun, Mar 17, 2019 at 02:20:19AM +0100, Pavel Machek wrote:
> > On Fri 2019-03-15 21:13:42, Andy Shevchenko wrote:
> > > There is no evidence of officially registered ACPI IDs for these devices.
> > > Thus, revert commit 44b3e31d540e917a4d2292b902ade63fa1748d9a.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > 
> > NAK. I don't believe someone did that code without testing.
> 
> Testing is irrelevant here.

Do you believe someone wrote that code without testing?

> 
> It's unlike device tree where IDs comes from thin air.
> Do you have any document in possession that supports legal base for these IDs
> being in the kernel?

Legal? ACPI specification was not law last time I checked.

(And: no.)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux