On čtvrtek 23. srpna 2018 22:14:45 CEST, Jacek Anaszewski wrote:
Braces are not necessary for single statement blocks. Moreover - I infer that you don't want to break on error here. If so, then we don't need the assignment and it is possible to get rid of two lines by changing it if (i2c_smbus_write_byte_data(priv->swrst_client, TLC591XX_RESET_BYTE_0, TLC591XX_RESET_BYTE_1)) dev_warn(dev, "SW reset failed\n"); I modified it as above and pushed to the for-4.20 branch of linux-leds.git. Please let me know if you have any objections regarding this change.
Thanks for fixing it and for a quick merge. The change looks OK. With kind regards, Jan
