On Fri, Jun 29, 2018 at 10:13:34PM +0200, Jacek Anaszewski wrote: > Uwe, > > Thanks for resending the patch set. > > I tested it with x86_64_defconfig and got following warnings: > > [...] > CC net/rfkill/core.o > CC net/netfilter/nf_conntrack_seqadj.o > CC net/netfilter/nf_conntrack_netlink.o > net/rfkill/core.c: In function ‘rfkill_led_trigger_register’: > net/rfkill/core.c:171:31: warning: assignment from incompatible pointer type > rfkill->led_trigger.activate = rfkill_led_trigger_activate; > ^ > CC net/ipv6/sysctl_net_ipv6.o > CC net/ipv4/tcp_recovery.o > [...] > CC net/mac80211/led.o > CC drivers/hid/hid-topseed.o > CC drivers/gpu/drm/i915/i915_gem_execbuffer.o > CC net/ipv4/netlink.o > AR drivers/hid/built-in.a > CC net/mac80211/pm.o > net/mac80211/led.c: In function ‘ieee80211_led_init’: > net/mac80211/led.c:148:25: warning: assignment from incompatible pointer > type > local->rx_led.activate = ieee80211_rx_led_activate; > ^ > net/mac80211/led.c:156:25: warning: assignment from incompatible pointer > type > local->tx_led.activate = ieee80211_tx_led_activate; > ^ > net/mac80211/led.c:164:28: warning: assignment from incompatible pointer > type > local->assoc_led.activate = ieee80211_assoc_led_activate; > ^ > net/mac80211/led.c:172:28: warning: assignment from incompatible pointer > type > local->radio_led.activate = ieee80211_radio_led_activate; > ^ > net/mac80211/led.c:181:27: warning: assignment from incompatible pointer > type > local->tpt_led.activate = ieee80211_tpt_led_activate; > > > It seems that will need net maintainer acks anyway :-) *sigh*, this wouldn't be a stopper if the conversion wouldn't have been done in a single step as was requested in (IIRC) v2 :-| Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
