On Fri, Jun 29, 2018 at 10:07:17AM +0200, Pavel Machek wrote: > Hi! > > > > There's no reason 2. should be in kernel ("mechanism, not policy"). > > > > > > Given 1. is not really more complicated than the morse > > > trigger... please just help with pattern trigger if you want this to > > > happen. > > > > Ah, you want to do the conversion to morse code in userspace? > > Yes, that makes sense. > > Yes, that's what I want. We all want a pony :) Seriously, this is a very simple module, works well, and makes some system's life much easier as there is no external dependancy on a text-to-morse-code library needed. If you don't want this cluttering up your kernel, don't built it in. I think it should be taken as-is (well, with the few changes already recommended). thanks, greg k-h