Hello, This is v5 of the series. The only relevant change since v4 is that I rebased on 961adc2fac2cb629384d2cbbb55262c9bc68e40a (i.e. for-next in the linux-leds.git) to allow nice patch application for Jacek after the can triggers are out of the way. Ahh, and I added some Acks by Pavel and one by Greg. Uwe Kleine-König (18): leds: remove unused function led_trigger_rename_static() leds: triggers: make the MODULE_LICENSE string match the actual license leds: triggers: let struct led_trigger::activate() return an error code leds: triggers: add device attribute support leds: triggers: handle .trigger_data and .activated() in the core leds: triggers: define module_led_trigger helper leds: triggers: new function led_set_trigger_data() leds: netdev trigger: simplifications from core changes leds: timer trigger: simplifications from core changes leds: transient trigger: simplifications from core changes leds: oneshot trigger: simplifications from core changes leds: heartbeat trigger: simplifications from core changes leds: default-on trigger: make use of module_led_trigger() leds: activity trigger: simplifications from core changes leds: backlight trigger: simplifications from core changes leds: gpio trigger: simplifications from core changes usb: simplify usbport trigger WIP: don't apply drivers/leds/led-triggers.c | 51 +++++++---- drivers/leds/trigger/ledtrig-activity.c | 46 +++++----- drivers/leds/trigger/ledtrig-backlight.c | 64 +++++--------- drivers/leds/trigger/ledtrig-camera.c | 3 +- drivers/leds/trigger/ledtrig-default-on.c | 20 +---- drivers/leds/trigger/ledtrig-gpio.c | 92 ++++++------------- drivers/leds/trigger/ledtrig-heartbeat.c | 49 +++++------ drivers/leds/trigger/ledtrig-netdev.c | 101 +++++++-------------- drivers/leds/trigger/ledtrig-oneshot.c | 91 ++++++------------- drivers/leds/trigger/ledtrig-timer.c | 58 ++++-------- drivers/leds/trigger/ledtrig-transient.c | 102 +++++++--------------- drivers/tty/vt/keyboard.c | 4 +- drivers/usb/core/ledtrig-usbport.c | 34 +++----- include/linux/leds.h | 58 ++++++------ 14 files changed, 292 insertions(+), 481 deletions(-) -- 2.18.0