On Mon, May 14, 2018 at 12:15:04PM +0200, Uwe Kleine-König wrote:
> The new function led_trigger_register_format allows one to simplify LED
> trigger handling considerably.
>
> Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/net/can/led.c | 30 +++++++-----------------------
> include/linux/can/dev.h | 3 ---
> 2 files changed, 7 insertions(+), 26 deletions(-)
>
> diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h
> index 055aaf5ed9af..ff358269aa9c 100644
> --- a/include/linux/can/dev.h
> +++ b/include/linux/can/dev.h
> @@ -73,11 +73,8 @@ struct can_priv {
>
> #ifdef CONFIG_CAN_LEDS
> struct led_trigger *tx_led_trig;
> - char tx_led_trig_name[CAN_LED_NAME_SZ];
> struct led_trigger *rx_led_trig;
> - char rx_led_trig_name[CAN_LED_NAME_SZ];
> struct led_trigger *rxtx_led_trig;
> - char rxtx_led_trig_name[CAN_LED_NAME_SZ];
> #endif
> };
Just a drive-by comment on this one; it seems you should also remove
CAN_LED_NAME_SZ, which is unused after this series.
Johan
