On 05/08/2018 10:32 AM, Andrew F. Davis wrote: > On 05/08/2018 09:17 AM, Dan Murphy wrote: >> Introduce the device tree bindings for the lm3601x >> family of LED torch, flash and IR drivers. >> >> Signed-off-by: Dan Murphy <dmurphy@xxxxxx> >> --- >> >> v2 - No changes - https://patchwork.kernel.org/patch/10384587/ >> >> .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> new file mode 100644 >> index 000000000000..38cdabf6ca7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> @@ -0,0 +1,51 @@ >> +* Texas Instruments - lm3601x Single-LED Flash Driver >> + >> +The LM3601X are ultra-small LED flash drivers that >> +provides a high level of adjustability. >> + >> +Required properties: >> + - compatible : Can be one of the following >> + "ti,lm3601x" > > > No wildcard compatibles, drop this. Yeah I hmm and hawed about keeping this so I figured I would get community feedback on this. I can remove it. > > >> + "ti,lm36010" >> + "ti,lm36011" >> + - reg : I2C slave address >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Required child properties: >> + - reg : 0 - Indicates to support and register a torch interface >> + 1 - Indicates to support and register a strobe interface >> + 2 - Indicates to support and register an ir interface >> + >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + > > > Relative path might work better here. I was following the other LED documentation. Pretty much a copy and paste > > >> +Example: >> +led-controller@64 { >> + compatible = "ti,lm3601x"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x64>; >> + >> + led@0 { >> + reg = <0>; >> + label = "white:torch"; >> + led-max-microamp=<10000>; >> + }; >> + >> + led@1 { >> + reg = <1>; >> + label = "white:strobe"; >> + flash-max-microamp=<10000>; >> + flash-max-timeout-us=<800>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + label = "invisible:ir"; >> + }; >> +} >> + >> +For more product information please see the links below: >> +http://www.ti.com/product/LM36010 >> +http://www.ti.com/product/LM36011 >> -- ------------------ Dan Murphy
