On Sat, 2018-04-21 at 09:50 +0100, Javier Arteaga wrote:
> Allow userspace to use the on-board LEDs as "upboard:<color>:".
> + struct upboard_led *led = container_of(cdev, struct
> upboard_led, cdev);
#define to_upboard_led(cdev) container_of(cdev, struct upboard_led,
cdev)
... led = to_upboard_led(cdev);
> + struct upboard_led *led = container_of(cdev, struct
> upboard_led, cdev);
Ditto.
> +static int __init upboard_led_probe(struct platform_device *pdev)
Are you sure about __init here?
> + struct upboard_led_data * const pdata = pdev-
> >dev.platform_data;
Don't use direct dereference to platform_data.
> + if (!pdev->dev.parent)
> + return -EINVAL;
> +
> + upboard = dev_get_drvdata(pdev->dev.parent);
> + if (!upboard || !pdata)
> + return -EINVAL;
Wouldn't be better to supply regmap as part of platform data?
It will allow be flexible of parent device.
> +MODULE_LICENSE("GPL");
License mismatch.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
