On Wed, Nov 02, 2016 at 09:22:44AM +0100, Jacek Anaszewski wrote: > Hi Mika, > > On 10/31/2016 09:47 AM, Mika Westerberg wrote: > > On Fri, Oct 28, 2016 at 12:08:57PM +0200, Jacek Anaszewski wrote: > > > > +static struct platform_driver led_driver = { > > > > + .probe = ni78bx_add, > > > > + .remove = ni78bx_remove, > > > > + .driver = { > > > > + .name = KBUILD_MODNAME, > > > > + .acpi_match_table = ACPI_PTR(led_device_ids), > > > > > > Please CC ACPI maintainers always if you include acpi.h > > > Cc Rafael and Mika. > > > > > From ACPI perspective this driver looks fine to me now. > > Thanks for the review. Can I add your Acked-by then? Sure, Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html