Hi Amitesh, On 09/03/2016 11:03 AM, Amitesh Singh wrote:
This patch facilates the blink delay to be passed as an argument at the time of module loading. e.g. insmod ledtrigg-oneshot.ko default_delay=100 --- drivers/leds/trigger/ledtrig-oneshot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-oneshot.c b/drivers/leds/trigger/ledtrig-oneshot.c index b8ea9f0..95933a1 100644 --- a/drivers/leds/trigger/ledtrig-oneshot.c +++ b/drivers/leds/trigger/ledtrig-oneshot.c @@ -22,6 +22,9 @@ #define DEFAULT_DELAY 100 +static unsigned long default_delay = DEFAULT_DELAY; +module_param(default_delay, ulong, S_IRUGO|S_IWUSR); + struct oneshot_trig_data { unsigned int invert; }; @@ -146,8 +149,8 @@ static void oneshot_trig_activate(struct led_classdev *led_cdev) if (rc) goto err_out_invert; - led_cdev->blink_delay_on = DEFAULT_DELAY; - led_cdev->blink_delay_off = DEFAULT_DELAY; + led_cdev->blink_delay_on = default_delay; + led_cdev->blink_delay_off = default_delay; led_cdev->activated = true;
Why do you need this module parameter? You can change delay_on and delay_off values from sysfs. -- Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html