On Fri, Jun 24, 2016 at 03:51:14PM +0200, Rafael J. Wysocki wrote: > > +#ifdef CONFIG_ACPI > > +static const struct acpi_device_id lp3952_acpi_match[] = { > > + {LP3952_NAME, 0}, > > The above line is not necessary AFAICS. Mika? Indeed, it should not be there. > > + {LP3952_ACPI_NAME, 0}, > > + {} > > +}; > > + > > +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match); > > +#endif > > + > > +static struct i2c_driver lp3952_i2c_driver = { > > + .driver = { > > + .name = LP3952_NAME, > > + .owner = THIS_MODULE, > > +#ifdef CONFIG_ACPI > > + .acpi_match_table = ACPI_PTR(lp3952_acpi_match), > > +#endif Also this #ifdeffery is not needed either. > > + }, > > + .probe = lp3952_probe, > > + .remove = lp3952_remove, > > + .id_table = lp3952_id, > > +}; -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html