Hi Tony, On 05/19/2016 05:57 PM, Tony Makkiel wrote:
Hi, Is there any particular reason to stipulate, (hardware) blink should be turned off, when brightness is set to 0? Following is copied from "Documentation/leds/leds-class.txt" "Setting the brightness to zero with brightness_set() callback function should completely turn off the LED and cancel the previously programmed hardware blinking function, if any." The chip driver could also use other methods for the same, keeping brightness independent of blink. For example, delay_on/off delay_off=0 ==> blink off, led on. delay_on=0 ==> blink off, led off. Or am I overlooking something?
Setting brightness to zero not only disables blinking but also any other active trigger. Besides, would it make sense to have blinking enabled with brightness set to 0? Anyway, we have to keep this interface as-is so as not to break existing users of the LED API. -- Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
