On Tue, 11 Aug 2015 15:00:38 +0300, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > One thing I noticed: > > qnap_tsx51_leds_platform_device = platform_device_register_resndata(NULL, "led-gpio", -1, NULL, 0, > &qnap_tsx51_led_data, sizeof(qnap_tsx51_led_data)); > > The driver expects "leds-gpio" not "led-gpio". And indeed, this is what was preventing proper detection. Very nice catch, thanks a lot. Now, I see two more things I need to do and for which I have no idea: - Somehow depend on gpio-f7188x and cause leds-gpio to get loaded (is it a dependence too ?). Module writing documentation mention soft dependencies, but it feels wrong here. - Somehow detect that it is actually a qnap of expected model (and, by extension, actually implement led count substraction). I tried (and failed so far) to understand what the original firmware does. dmidecode does not bring something relevant. I have no idea what is typically done in this area. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
