Hi Ricardo, On Wed, Mar 25, 2015 at 10:20:59AM +0100, Ricardo Ribalda Delgado wrote: > Hi Sakari > > On Wed, Mar 25, 2015 at 1:54 AM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > I'd use dev_warn() or even WARN_ON(ret). This is a rather serious issue as > > now the probe order defines the name of the device. There might be something > > better such as the I2C bus/address. > > I have no problem in sending a dev_warn, WARN_ON looks too much to me. > > In my example (dt overlays), it is perfectly ok to have duplicated names. > > > > > If the registration order for some reason changes, that'd revert the device > > names. In Media controller this is part of the user space API. > > Would it be possible for media controller leds to have a name based on > their address? It's included where there's a stable address. That's not true for GPIO controlled devices though, it's a GPIO controller plus a number. Ramming lots of information to the media entity's name field is not possible since it's just 32 bytes; for this reason we're looking to implement a better way to recognise devices in MC. But for now, we got to cope with what we have. > Regarding s/dev_info/dev_warn : Do you want to send the patch or I should do it? Is this one merged already? If yes, sure I can. Otherwise a new version would be nice. -- Cheers, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
