On Sun, Sep 28, 2014 at 1:57 AM, Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> wrote: > Since we cannot make sure the 'pdata->num_leds' will always be none > zero here, and then if it equals to zero, the kmemdup() will return > ZERO_SIZE_PTR, which equals to ((void *)16). > > So this patch fix this with just doing the zero check before calling > kmemdup(). > Thanks, applied. -Bryan > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> > --- > drivers/leds/leds-gpio-register.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c > index fbd8934..75717ba 100644 > --- a/drivers/leds/leds-gpio-register.c > +++ b/drivers/leds/leds-gpio-register.c > @@ -28,6 +28,9 @@ struct platform_device *__init gpio_led_register_device( > struct platform_device *ret; > struct gpio_led_platform_data _pdata = *pdata; > > + if (!pdata->num_leds) > + return ERR_PTR(-EINVAL); > + > _pdata.leds = kmemdup(pdata->leds, > pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL); > if (!_pdata.leds) > -- > 2.1.0.27.g96db324 > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
