On Tue, Jul 15, 2014 at 2:46 AM, Bryan Wu <cooloney@xxxxxxxxx> wrote: > On Sat, Jul 12, 2014 at 2:32 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: >> + if (*delay_off >= IPAQ_LED_MAX_DUTY) >> + msg.tx_data[3] = 0; >> + else >> + msg.tx_data[3] = (u8) DIV_ROUND_CLOSEST(*delay_off, 100); >> + return ipaq_micro_tx_msg_sync(micro, &msg); > > Do we need to use workqueue for both .brightness_set and .blink_set? The LED message is basically just that you send a message and this sync function waits for an ACK to be returned from a completion after an interrupt. It really does not involve a workqueue, it's a message queue. Fixed up the rest, sending v2 soon... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
