* Bryan Wu <cooloney@xxxxxxxxx> [130701 12:12]: > On Thu, Jun 27, 2013 at 7:24 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Tony Lindgren <tony@xxxxxxxxxxx> [130627 00:28]: > >> * Bryan Wu <cooloney@xxxxxxxxx> [130626 16:53]: > >> > On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > >> > > @@ -22,6 +22,7 @@ > >> > > #include <linux/i2c.h> > >> > > #include <linux/workqueue.h> > >> > > #include <linux/slab.h> > >> > > +#include <linux/of.h> > >> > > #include <linux/platform_data/leds-pca9633.h> > >> > > > >> > > /* LED select registers determine the source that drives LED outputs */ > >> > > @@ -93,6 +94,61 @@ static void pca9633_led_set(struct led_classdev *led_cdev, > >> > > schedule_work(&pca9633->work); > >> > > } > >> > > > >> > > +#ifdef CONFIG_OF > >> > > >> > Shall we use "#if IS_ENABLED(CONFIG_OF)", as Grant pointed out recently. > >> > >> Thanks will do, I'll also add the push-pull vs totem pole binding > >> as that can be quite crucial for some hardware configurations. > > > > Here's the updated patch. > > > > Regards, > > > > Tony > > > > Thanks, I merged it into my -devel branch. And it targets for 3.12 > merge window, since 3.11 merge window opened right now. OK thanks! Tony -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html