On Mon, Nov 26, 2012 at 2:39 AM, Chris Wilson <chris@xxxxxxxxxxxx> wrote: > Hi Bryan, > > > On Mon, 13 Aug 2012, Bryan Wu wrote: > >> [Bryan] >> This is wrong, platform_device should be created in machine board >> files not in the drivers. For x86, please take a look at >> drivers/platform/x86/. And for leds-hp6xx.c, I didn't find any user of >> this in arch/sh. So probably we can drop it sometime. >> >> I also suggest you can just add this driver into the machine board >> file of this Soekris machine in drivers/platform/x86/ like other >> machines do. Please take a look at >> drivers/platform/x86/thinkpad_acpi.c, it includes fully leds supports >> for ThinkPad machine. > > > Rereading your message I am wondering if I misunderstood you. Do you think I > should convert the entire Net6501 LEDs driver into a platform driver, and > ask the platform guys to accept it? Even though it will probably only ever > contain LEDs? > Right, the Net6501 LEDs driver can be easily added as part of platform driver and it looks more reasonable. Looks at those x86 platform driver, they do all the tricks of x86 machines. If the LED driver is quite common and can be shared by others, we can add it to drivers/leds. Otherwise I think platform driver is a better solution. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
