Hi Bryan, On Mon, 13 Aug 2012, Bryan Wu wrote:
[Bryan] This is wrong, platform_device should be created in machine board files not in the drivers. For x86, please take a look at drivers/platform/x86/. And for leds-hp6xx.c, I didn't find any user of this in arch/sh. So probably we can drop it sometime. I also suggest you can just add this driver into the machine board file of this Soekris machine in drivers/platform/x86/ like other machines do. Please take a look at drivers/platform/x86/thinkpad_acpi.c, it includes fully leds supports for ThinkPad machine.
Rereading your message I am wondering if I misunderstood you. Do you think I should convert the entire Net6501 LEDs driver into a platform driver, and ask the platform guys to accept it? Even though it will probably only ever contain LEDs?
Cheers, Chris. -- Aptivate | http://www.aptivate.org | Phone: +44 1223 967 838 Future Business, Cam City FC, Milton Rd, Cambridge, CB4 1UY, UK Aptivate is a not-for-profit company registered in England and Wales with company number 04980791. -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
