On Mon, Dec 9, 2024 at 9:51 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Mon, Dec 09, 2024 at 09:26:01PM +0800, Weizhao Ouyang wrote: > > > > If we don't have SME we should be skipping over all the SME code and > > > never even looking at the value of SVCR. Looking at the current version > > > of the code it does that, it branches to check_sve_in if SME is not > > > enabled. > > > Yes we should skip it, this is just a minor tweak based on the > > current implementation, after all, we manually passed its value by > > svcr_in. > > It's a fairly trivial tweak to make... in any case, it looks like we > also need the same change in the save path. Yeah. I have encountered this issue with both QEMU and FVP. I can help to add a check_sve_in similar to the fp testcase for the abi testcase. BR, Weizhao > > > Which latest code version are you referring to? I think check_sve_in > > is in fp testcase, not in the abi testcase. (checked the -next tree) > > Ah, yes sorry.