Thank you for your feedback and patience Andy. I apologize about the hastiness of the v2 patch. I've addressed the feedback and would like to wait for any additional reviews before sending out a v3. In the meantime I wanted to answer the questions posed to the best of my ability. > Shouldn't the thing to be in lib/tests/Kconfig? The Kconfig entries for lib/math are located in lib/Kconfig.debug as per David Gow in https://lore.kernel.org/all/CABVgOS=-vh5TqHFCq_jo=ffq8v_nGgr6JsPnOZag3e6+19ysxQ@xxxxxxxxxxxxxx/ > Where is this? I don't see it right now in the Linux Next... It's a previous kunit test suite, it should be in both next and mainline Makefile: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/lib/math/tests/Makefile?h=next-20241025 Kunit Test: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/lib/math/tests/int_pow_kunit.c?h=next-20241025 Kconfig entry: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/lib/Kconfig.debug?h=next-20241025#n3103 The Kconfig entry was fixed in next by Kuan-Wei Chiu in https://lore.kernel.org/all/20241005222221.2154393-1-visitorckw@xxxxxxxxx/ which I had incorrectly placed at the top-level in my original patch, hence the discrepancy in the location on mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/Kconfig.debug?h=v6.12-rc4#n3092 One more thing to note is that there is a patch that organized the tests in lib/math as per the documentation: https://lore.kernel.org/all/20241005222446.10471-1-luis.hernandez093@xxxxxxxxx/ Which resulted in a conflict and the fix was carried over: https://lore.kernel.org/all/20241009162719.0adaea37@xxxxxxxxxxxxxxxx/ Again, I appreciate your time and review. I hope this answered some of your questions. I'll continue to follow this thread so as to make any additional fixes from further reviews before sending out the next version. Best regards, Felipe
