On Thu, Oct 24, 2024 at 03:55:09PM -0400, Luis Felipe Hernandez wrote: > Adds test suite for integer based square root function. > > The test suite is designed to verify the correctness of the int_sqrt int_aqrt() > math library function. ... > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > +config INT_SQRT_KUNIT_TEST > + tristate "Integer square root test test" if !KUNIT_ALL_TESTS > + depends on KUNIT > + default KUNIT_ALL_TESTS > + help > + This option enables the KUnit test suite for the int_sqrt function, > + which performs square root calculation. The test suite checks > + various scenarios, including edge cases, to ensure correctness. > + > + Enabling this option will include tests that check various scenarios > + and edge cases to ensure the accuracy and reliability of the square root > + function. > + > + If unsure, say N > + > + One blank line is enough. Shouldn't the thing to be in lib/tests/Kconfig? ... > obj-$(CONFIG_INT_POW_TEST) += int_pow_kunit.o Where is this? I don't see it right now in the Linux Next... ... > +#include <kunit/test.h> > +#include <linux/math.h> > +#include <linux/module.h> > +#include <linux/string.h> > +#include <limits.h> linux/limits.h, of course. Sorry that I wasn't clear about this, but it's kinda rule of thumb that all headers in 99.999% kernel-space related files in the Linux kernel are from in-project folders and not from outside. -- With Best Regards, Andy Shevchenko
