Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/17/24 12:44, Andrew Morton wrote:
> On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual <anshuman.khandual@xxxxxxx> wrote:
> 
>> On 10/15/24 07:32, Nanyong Sun wrote:
>>> The mount option of tmpfs should be huge=advise, not madvise
>>> which is not supported and may mislead the users.
>> Agreed.
>>
>>> Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing")
>> But nothing is really broken here. This just fixes usage information.
> The usage information is broken!
> 
>> Please drop the "Fixes:".
> Fixes: is appropriate.  It tells people which commit introduced the error.
> 
> I don't think it's serious enough to add a cc:stable.  Others might disagree.

Alright, usage information is part of the functionality itself.




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux