On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual <anshuman.khandual@xxxxxxx> wrote:
> On 10/15/24 07:32, Nanyong Sun wrote:
> > The mount option of tmpfs should be huge=advise, not madvise
> > which is not supported and may mislead the users.
>
> Agreed.
>
> >
> > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing")
>
> But nothing is really broken here. This just fixes usage information.
The usage information is broken!
> Please drop the "Fixes:".
Fixes: is appropriate. It tells people which commit introduced the error.
I don't think it's serious enough to add a cc:stable. Others might disagree.
> > Signed-off-by: Nanyong Sun <sunnanyong@xxxxxxxxxx>
> > ---
> > tools/testing/selftests/mm/khugepaged.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c
> > index 56d4480e8d3c..8a4d34cce36b 100644
> > --- a/tools/testing/selftests/mm/khugepaged.c
> > +++ b/tools/testing/selftests/mm/khugepaged.c
> > @@ -1091,7 +1091,7 @@ static void usage(void)
> > fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built with\n");
> > fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n");
> > fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs must be\n");
> > - fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to work\n");
> > + fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to work\n");
> > fprintf(stderr, "\n\tSupported Options:\n");
> > fprintf(stderr, "\t\t-h: This help message.\n");
> > fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n");
>
> Without the above "Fixes:" tag,
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
Thanks.
