Paolo Abeni <pabeni@xxxxxxxxxx> writes: > On 10/9/24 14:06, Petr Machata wrote: >> @@ -450,6 +415,7 @@ __do_ecn_test() >> start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ >> $h3_mac tos=0x01 >> + defer stop_traffic $! >> sleep 1 >> ecn_test_common "$name" "$get_nmarked" $vlan $limit >> @@ -462,7 +428,6 @@ __do_ecn_test() >> check_fail $? "UDP traffic went into backlog instead of being early-dropped" >> log_test "TC $((vlan - 10)): $name backlog > limit: UDP early-dropped" >> - stop_traffic >> sleep 1 > > I'm wodering what role/goal has the above 'sleep 1'?!? It looks like it could/should be removed > after moving the stop_traffic call to the deferred cleanup. Yeah, I'll drop these for v2.