Akihiko Odaki wrote: > On 2024/10/09 22:51, Willem de Bruijn wrote: > > Akihiko Odaki wrote: > >> They are useful to implement VIRTIO_NET_F_RSS and > >> VIRTIO_NET_F_HASH_REPORT. > >> > >> Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> > >> --- > >> include/linux/virtio_net.h | 188 +++++++++++++++++++++++++++++++++++++++++++++ > > > > No need for these to be in header files > > I naively followed prior examples in this file. Do you have an > alternative idea? This is long overdue really, not specific to this fuatre. And extends to your patch 4 that deduplicates tun.c and tap.c. Perhaps drivers/net/virtio_net_hdr.c. Or drivers/net/tun_vnet.c, matching your choice of drivers/net/tun_vnet.h.
