On 10/9/24 11:46, Jakub Sitnicki wrote: > That's curious. We don't override the proto::sendmsg callback for > protocols which don't support sk_msg redirects, like UDP: > > https://elixir.bootlin.com/linux/v6.12-rc2/source/net/ipv4/udp_bpf.c#L114 > > The packet should get delivered to the peer socket as w/o sockmap. > I will have to double check that. Ugh, no, you're right. I was checking the wrong queue all that time... Sorry for the confusion. > Thanks. And yes - if possible, better to push fixes separately. Because > they go through the bpf tree, and they will still land in the upcoming > -rc releases (and get backported). > > While improvements go through bpf-next. Of course that sometimes makes > life more difficult if the improvements depend on some fixes... I'm afraid that's the case for the redir selftest to run cleanly. Anyway, so those are the fixes mentioned, targeting bpf: https://lore.kernel.org/bpf/20241009-vsock-fixes-for-redir-v1-0-e455416f6d78@xxxxxxx/ > Not sure if anything from bpf-next gets backported if it has a Fixes > tag. We can ask the stable kernel maintainers, if needed.
