On Tue, Aug 27, 2024 at 09:59:53AM -0700, Nicolin Chen wrote: > static const struct iommu_domain_ops arm_smmu_nested_ops = { > .get_msi_mapping_domain = arm_smmu_get_msi_mapping_domain, > .attach_dev = arm_smmu_attach_dev_nested, > .free = arm_smmu_domain_nested_free, > + .cache_invalidate_user = arm_smmu_cache_invalidate_user, > }; I think we should drop this op. The original intention was to do things in parts to split up the patches, but it turns out this is functionally useless so lets not even expose it to userspace. So the patch can maybe be split differently and combined with the next patch Jason