On Fri, 02 Aug 2024 13:43:03 +0100, Mark Brown <broonie@xxxxxxxxxx> wrote: > > [1 <text/plain; us-ascii (7bit)>] > On Fri, Aug 02, 2024 at 10:00:28AM +0100, Marc Zyngier wrote: > > > Also, the test predates the generated stuff by some margin. > > Yeah, there were still defines in the main kernel source that were being > retyped rather than shared previously which made me wonder. Definitions in the kernel are likely to exist for a long time though, as the tool is still pretty primitive and doesn't handle anything that changes layout (such as any register affected by E2H). > > > Mark Brown <broonie@xxxxxxxxxx> wrote: > > > > I'd certainly be happy to convert, though that does > > > seem a bit invasive for a fix. > > > Not for a point fix, for sure. And if you do, make sure it is entirely > > scripted. > > When you say "entirely scripted" here I take it you're referring to the > list of registers as well, and I guess also to the information about > what is enumerated by which ID register values? The register list is indeed the #1 offender, and that should just be a script that goes over all the occurrences of ARM64_SYS_REG() and replace the encoding with something that uses the symbolic name. For the rest (shifts and stuff), we can probably do that by hand (there are only a few occurrences). M. -- Without deviation from the norm, progress is not possible.
