On 6/10/24 10:59, Kees Cook wrote:
On Fri, Jun 07, 2024 at 02:58:47PM -0600, Shuah Khan wrote:
On 6/7/24 06:41, Amer Al Shanawany wrote:
fix the following errors by removing empty print statements:
seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
197 | ksft_print_msg("");
| ^~
seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
202 | ksft_print_msg("");
| ^~
seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
204 | ksft_print_msg("");
| ^~
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@xxxxxxxxx/
Signed-off-by: Amer Al Shanawany <amer.shanawany@xxxxxxxxx>
---
Changes v1 -> v2:
removed empty print statements
Kees,
Is this change okay with you. I didn't see any use for
these empty ksft_print_msg().
I will take this patch if you are okay with the change.
Dropping these means that the "#" marks go missing. Currently:
# Running on:
# Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
with the proposed patch:
# Running on:
Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
This breaks the TAP syntax for the test, so we should find a different
solution.
Perhaps:
ksft_print_msg("%s", "");
?
Thank you Kees. Yes that would work.
Amer, please send me v3 based on Kees's suggestions.
thanks,
-- Shuah
