On 6/7/24 06:41, Amer Al Shanawany wrote:
fix the following errors by removing empty print statements:
seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
197 | ksft_print_msg("");
| ^~
seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
202 | ksft_print_msg("");
| ^~
seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format
string [-Wformat-zero-length]
204 | ksft_print_msg("");
| ^~
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@xxxxxxxxx/
Signed-off-by: Amer Al Shanawany <amer.shanawany@xxxxxxxxx>
---
Changes v1 -> v2:
removed empty print statements
Kees,
Is this change okay with you. I didn't see any use for
these empty ksft_print_msg().
I will take this patch if you are okay with the change.
---
tools/testing/selftests/seccomp/seccomp_benchmark.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/seccomp/seccomp_benchmark.c b/tools/testing/selftests/seccomp/seccomp_benchmark.c
index b83099160fbc..6fe34be6c693 100644
--- a/tools/testing/selftests/seccomp/seccomp_benchmark.c
+++ b/tools/testing/selftests/seccomp/seccomp_benchmark.c
@@ -194,14 +194,11 @@ int main(int argc, char *argv[])
ksft_set_plan(7);
ksft_print_msg("Running on:\n");
- ksft_print_msg("");
system("uname -a");
ksft_print_msg("Current BPF sysctl settings:\n");
/* Avoid using "sysctl" which may not be installed. */
- ksft_print_msg("");
system("grep -H . /proc/sys/net/core/bpf_jit_enable");
- ksft_print_msg("");
system("grep -H . /proc/sys/net/core/bpf_jit_harden");
affinity();
thanks,
-- Shuah
