Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/6/24 7:44 AM, Mark Brown wrote:
On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote:
Jaroslav Kysela wrote:

This function is nice for debugging. I'd prefer to keep it with the fix.

I'm find in either way; just submit a fix patch, then.

The fix was already submitted as v1, I noticed that the function was
unused in review.

It's generally considered a best practice to delete unused code. If
there is something you especially like for upcoming code, you still
have git history, and even a lore.kernel.org link, to bookmark it.

So I'd recommend going with v2, but of course it's your call! :)


thanks,
--
John Hubbard
NVIDIA





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux