On Mon, 06 May 2024 09:27:38 +0200, Jaroslav Kysela wrote: > > On 06. 05. 24 9:19, Takashi Iwai wrote: > > On Sun, 05 May 2024 23:08:24 +0200, > > John Hubbard wrote: > >> > >> dump_config_tree() is declared to return an int, but the compiler cannot > >> prove that it always returns any value at all. This leads to a clang > >> warning, when building via: > >> > >> make LLVM=1 -C tools/testing/selftests > >> > >> Furthermore, Mark Brown noticed that dump_config_tree() isn't even used > >> anymore, so just delete the entire function. > >> > >> Cc: Mark Brown <broonie@xxxxxxxxxx> > >> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx> > > > > Thanks, applied now. > > This function is nice for debugging. I'd prefer to keep it with the fix. I'm find in either way; just submit a fix patch, then. thanks, Takashi