On Mon, 14 Aug 2023 17:06:10 +0200 Sabrina Dubroca wrote: > 2023-08-11, 18:43:47 -0700, Jakub Kicinski wrote: > > On Wed, 9 Aug 2023 14:58:52 +0200 Sabrina Dubroca wrote: > > > TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSRXSW); > > > TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSCURRRXSW); > > > conf = TLS_SW; > > > > Should we add a statistic for rekeying? > > Hmpf, at least I shouldn't be incrementing the existing stats on every > update, especially not TLSCURR* :/ > > I don't see much benefit in tracking succesful rekeys. Failed rekeys > seem more interesting to me. What would we get from counting succesful > rekeys? No huge benefit from counting rekeys, the main (only?) one I see is that when user reports issues we can see whether rekeys were involved (given that they are fairly rare). It could help narrow down triage.
