On Wed, 9 Aug 2023 14:58:52 +0200 Sabrina Dubroca wrote: > TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSRXSW); > TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSCURRRXSW); > conf = TLS_SW; Should we add a statistic for rekeying? > +int tls_set_sw_offload(struct sock *sk, int tx, > + struct tls_crypto_info *new_crypto_info) > { This function is already 300 LoC and we're making longer with a not-so-pretty goto skip; Any way we can refactor it first? I think someone had a plan to at least make the per-algo stuff less verbose?