On Fri, May 26, 2023 at 03:53:54PM +0800, David Gow wrote: > KUnit aborts the current thread when an assertion fails. Currently, this > is done conditionally as part of the kunit_do_failed_assertion() > function, but this hides the kunit_abort() call from the compiler > (particularly if it's in another module). This, in turn, can lead to > both suboptimal code generation (the compiler can't know if > kunit_do_failed_assertion() will return), and to static analysis tools > like smatch giving false positives. > > Moving the kunit_abort() call into the macro should give the compiler > and tools a better chance at understanding what's going on. Doing so > requires exporting kunit_abort(), though it's recommended to continue to > use assertions in lieu of aborting directly. > > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> Awesome thanks! I had already hardcoded the current behavior but I'm happy to delete that code. This works automatically and will continue to work if we change the parameters to kunit_do_failed_assertion() in the future. regards, dan carpenter
