Re: [PATCH bpf] selftests/bpf: fix pkg-config call building sign-file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/27/23 9:58 PM, Jeremy Sowden wrote:
On 2023-04-27, at 08:52:27 +0200, Roberto Sassu wrote:
On Wed, 2023-04-26 at 22:50 +0100, Jeremy Sowden wrote:
When building sign-file, the call to get the CFLAGS for libcrypto is
missing white-space between `pkg-config` and `--cflags`:

   $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)

Removing the redirection of stderr, we see:

   $ make -C tools/testing/selftests/bpf sign-file
   make: Entering directory '[...]/tools/testing/selftests/bpf'
   make: pkg-config--cflags: No such file or directory
     SIGN-FILE sign-file
   make: Leaving directory '[...]/tools/testing/selftests/bpf'

Add the missing space.

Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>

Thanks.

Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>

Roberto

Thanks.  I was having e-mail problems yesterday when I sent the original
message with the patch in it, and it didn't reach some of the
recipients.  I'll send it again with your `Reviewed-by:` attached.

No need, already took it, thanks. Looks like patchbot did not reply. :/

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=415d7a49cd796a11cfbeaa360b13721bba5117bb



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux